Test Wiki:Community portal: Difference between revisions
From Test Wiki
m
Fix link
(→MediaWiki:Gadget-markadmins.js: reply) |
m (Fix link) |
||
| Line 353: | Line 353: | ||
== [[MediaWiki:Gadget-markadmins.js]] == | == [[MediaWiki:Gadget-markadmins.js]] == | ||
Can someone (preferably an IA/S/SA) review [[User:NguoiDungKhongDinhDanh/Gadget-markadmins.js|my version]] of the gadget and then merge it? I tweaked it so as to automate the ''get''ting process. That being said, if my version is approved, we will no longer have to edit [[MediaWiki:Gadget-markadmins. | Can someone (preferably an IA/S/SA) review [[User:NguoiDungKhongDinhDanh/Gadget-markadmins.js|my version]] of the gadget and then merge it? I tweaked it so as to automate the ''get''ting process. That being said, if my version is approved, we will no longer have to edit [[MediaWiki:Gadget-markadmins.json|the JSON page]] manually. [[User:NguoiDungKhongDinhDanh|NguoiDungKhongDinhDanh]] ([[User talk:NguoiDungKhongDinhDanh|talk]]) 19:59, 12 March 2022 (UTC) | ||
:[[User:NguoiDungKhongDinhDanh|NguoiDungKhongDinhDanh]], though this exceeds my level of JS scripting expertise, this ''seems'' reasonable and, looking at your code, there does not seem to be any potential issues. As such, I've <br /> {{Done|[[Special:Diff/20691|done]]}} this request for you. However, I'd like [[User:Arcversin|Arcversin]] to take a second look, though, making any tweaks/revisions, as required. Also, I know I've asked you to confirm your Miraheze account on Wikimedia, but can you also provide a Wikimedia confirmation edit for your Test Wiki account? Thanks. :) [[User:Dmehus|Dmehus]] ([[User talk:Dmehus|talk]]) 22:48, 13 March 2022 (UTC) | :[[User:NguoiDungKhongDinhDanh|NguoiDungKhongDinhDanh]], though this exceeds my level of JS scripting expertise, this ''seems'' reasonable and, looking at your code, there does not seem to be any potential issues. As such, I've <br /> {{Done|[[Special:Diff/20691|done]]}} this request for you. However, I'd like [[User:Arcversin|Arcversin]] to take a second look, though, making any tweaks/revisions, as required. Also, I know I've asked you to confirm your Miraheze account on Wikimedia, but can you also provide a Wikimedia confirmation edit for your Test Wiki account? Thanks. :) [[User:Dmehus|Dmehus]] ([[User talk:Dmehus|talk]]) 22:48, 13 March 2022 (UTC) | ||
::{{ping|NguoiDungKhongDinhDanh}} {{ping|Dmehus}} Looking over the new script, it's fine, however there are a few small mistakes in terms of compatibility. MediaWiki only supports ECMAScript 5 (as opposed to 6) in most places (notably, this does not apply to scripts loaded directly from a URL), which means that you need to use the <code>var</code> keyword instead of <code>let</code>, which I've fixed. Also, making use of <code>mw.Api</code> requires that a dependency on <code>mediawiki.api</code> be added in [[MediaWiki:Gadgets-definition]], which has been done. Apart from that, the code works quite well. Do note that it would need an update should TestWiki grow to >500 sysops. — <span style="font-variant: small-caps">[[User:Arcversin|Arcversin]] ([[User talk:Arcversin|talk]])</span> 01:59, 14 March 2022 (UTC) | ::{{ping|NguoiDungKhongDinhDanh}} {{ping|Dmehus}} Looking over the new script, it's fine, however there are a few small mistakes in terms of compatibility. MediaWiki only supports ECMAScript 5 (as opposed to 6) in most places (notably, this does not apply to scripts loaded directly from a URL), which means that you need to use the <code>var</code> keyword instead of <code>let</code>, which I've fixed. Also, making use of <code>mw.Api</code> requires that a dependency on <code>mediawiki.api</code> be added in [[MediaWiki:Gadgets-definition]], which has been done. Apart from that, the code works quite well. Do note that it would need an update should TestWiki grow to >500 sysops. — <span style="font-variant: small-caps">[[User:Arcversin|Arcversin]] ([[User talk:Arcversin|talk]])</span> 01:59, 14 March 2022 (UTC) | ||
